-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @babel/polyfill to 7.rc-1 #159
Comments
Additional testing reveals this isn't actually a problem, but even then I can't test if it does works until the errors are resolved. Bonus incentive (apart from installing a release candidate, which I don't think I have done on npm before): it removes ~30kb from the bundle size. |
Not sure about the stack error (happens only with the minified file), but IE<9 are hit by |
|
Next: this time |
Success, now we have the stack error in the normal build as well. It seems the |
IE points to this line: } else if ('0'.split(undefined, 0)[LENGTH]) {
internalSplit = function (separator, limit) {
return separator === undefined && limit === 0 ? [] : nativeSplit.call(this, separator, limit);
};
} As if |
Okay, the problem was in another version (core-js v2), excluding Excluding |
Updating to |
Update dependencies, except Babel. See #159
This update involves limiting
@babel/polyfill
quite a lot:Properly updating involves determining what stage <4 polyfills Citation.js & dependencies are using, and importing those manually.
After updating and creating a bundle, running it on IE8 gives an
Out of stack space
error which has been linked to a lack of proper polyfills before. In conclusion, updating properly is most likely necessary. If not, I'll have to figure out what is causing this instead.The text was updated successfully, but these errors were encountered: