Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for memory issue of *> #72

Merged
merged 4 commits into from
Dec 31, 2018
Merged

Workaround for memory issue of *> #72

merged 4 commits into from
Dec 31, 2018

Conversation

barambani
Copy link
Member

This attempts mitigating the possible effects of the issue typelevel/cats-effect#401 that's still open.

@codecov-io
Copy link

codecov-io commented Dec 28, 2018

Codecov Report

Merging #72 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   22.94%   22.99%   +0.04%     
==========================================
  Files          33       33              
  Lines         950      948       -2     
  Branches       16       17       +1     
==========================================
  Hits          218      218              
+ Misses        732      730       -2
Impacted Files Coverage Δ
...src/main/scala/laserdisc/fs2/RedisConnection.scala 0% <0%> (ø) ⬆️
fs2/src/main/scala/laserdisc/fs2/RedisClient.scala 0% <0%> (ø) ⬆️
cli/src/main/scala/laserdisc/cli/CLI.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 006b205...6202efa. Read the comment docs.

sirocchj
sirocchj previously approved these changes Dec 30, 2018
fs2/src/main/scala/laserdisc/fs2/RedisConnection.scala Outdated Show resolved Hide resolved
Copy link
Member

@sirocchj sirocchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@barambani barambani merged commit 1fc5b21 into laserdisc-io:master Dec 31, 2018
@barambani barambani deleted the memory-issue-workaround branch December 31, 2018 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants