Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to CE3 #336

Merged
merged 3 commits into from
May 13, 2021
Merged

Port to CE3 #336

merged 3 commits into from
May 13, 2021

Conversation

sirocchj
Copy link
Member

A few things to consider:

  1. the context bound : Async on the readme samples for RedisClient may need to be reviewed once we port laserdisc to CE3 and see what options we have
  2. there may be nicer ways to do unsafeRunSync in the tests, including importing cats-effect-testkit but I thought this was the most straightforward

@sirocchj sirocchj requested a review from barambani as a code owner May 13, 2021 11:20
@sirocchj
Copy link
Member Author

Btw, supersedes #325 #329 #332

@barambani barambani merged commit 97f7ad8 into laserdisc-io:master May 13, 2021
@sirocchj sirocchj deleted the port-to-ce3 branch March 13, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barambani barambani barambani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirocchj @barambani