Feature/106 sep point #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rcalaon
force-pushed
the
feature/106-sepPoint
branch
5 times, most recently
from
cd7accd
to
bae2faa
Compare
patkenneally
requested changes
Jul 20, 2023
src/fswAlgorithms/attGuidance/_GeneralModuleFiles/attitudePointingLibrary.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/attGuidance/_GeneralModuleFiles/attitudePointingLibrary.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/attGuidance/_GeneralModuleFiles/attitudePointingLibrary.cpp
Show resolved
Hide resolved
src/fswAlgorithms/attGuidance/_GeneralModuleFiles/attitudePointingLibrary.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/attGuidance/_GeneralModuleFiles/attitudePointingLibrary.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/attGuidance/_GeneralModuleFiles/attitudePointingLibrary.h
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/attGuidance/sepPoint/_UnitTest/test_sepPoint0.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/attGuidance/sepPoint/_UnitTest/test_sepPoint0.py
Outdated
Show resolved
Hide resolved
rcalaon
force-pushed
the
feature/106-sepPoint
branch
4 times, most recently
from
cbce4f4
to
f615576
Compare
rcalaon
force-pushed
the
feature/106-sepPoint
branch
from
f615576
to
f3103a2
Compare
rcalaon
force-pushed
the
feature/106-sepPoint
branch
5 times, most recently
from
5a2366d
to
7d0d1b2
Compare
patkenneally
force-pushed
the
feature/106-sepPoint
branch
from
7d0d1b2
to
76ea68b
Compare
rcalaon
force-pushed
the
feature/106-sepPoint
branch
2 times, most recently
from
5f64a68
to
e5f2b1d
Compare
patkenneally
force-pushed
the
feature/106-sepPoint
branch
from
e5f2b1d
to
1cc26ff
Compare
patkenneally
approved these changes
Sep 12, 2023
patkenneally
force-pushed
the
feature/106-sepPoint
branch
from
1cc26ff
to
7a7a490
Compare
patkenneally
force-pushed
the
feature/106-sepPoint
branch
from
7a7a490
to
2aed389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch delivers a module sepPoint that is a refactored version of the already existing oneAxisSolarArrayPoint. This new version focuses on a single flight mode and univocally defines the input messages and input parameters to the module. The new module incorporates a new feature that enables the user to choose which pointing requirements to prioritize, after the main thruster pointing requirement is met. In the first commit, a library of utility function is created inside the attGuidance folder, which contains functions used in this module and in similar future modules. Commit 2 initializes the module files. Commit 3 populates the Reset function to check that all the inputs are connected correctly. Commit 4 contains the bulk of the module, where the Update function is populated, and the output message is computed and written. Commits 5 and 6 contain the unit tests and the documentation, respectively.
Verification
Two unit tests are provided, to test the correct functionality of the module with the two different sets of priorities.
Documentation
Documentation is provided to describe how to use the module.
Future work
Future work will involve the development of more similar modules that use similar math, but satisfy the pointing requirements for different flight modes.