Feature/335 initialize icp #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
approved these changes
Aug 15, 2023
src/fswAlgorithms/pointCloudProcessing/initializeICP/initializeICP.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/pointCloudProcessing/initializeICP/initializeICP.h
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/pointCloudProcessing/initializeICP/initializeICP.h
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/pointCloudProcessing/initializeICP/_UnitTest/test_initICP.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/pointCloudProcessing/initializeICP/_UnitTest/test_initICP.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/pointCloudProcessing/initializeICP/_UnitTest/test_initICP.py
Show resolved
Hide resolved
src/fswAlgorithms/pointCloudProcessing/SICP/scalingIterativeClosestPoint.h
Show resolved
Hide resolved
thibaudteil
force-pushed
the
feature/335-InitializeICP
branch
from
726a0a7
to
d4d3173
Compare
added 7 commits
August 16, 2023 18:23
thibaudteil
force-pushed
the
feature/335-InitializeICP
branch
from
d4d3173
to
9c71578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This module is needed to initialize the ICP process. It uses known spacecraft attitude/ephemeris information or previous ICP information to set the R,S,T values for ICP.
Verification
Unit test was added to test functionality
Documentation
Documentation in rst form was added
Future work
Improvements need to be added to use the filter solution and update which messages are read to initialize. Not an urgent chance for basic functionality