Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/357 update thr firing remainder module #129

Merged
merged 4 commits into from
Sep 9, 2023

Commits on Sep 9, 2023

  1. Change logic for first time step

    The first time the module is called, there is no information on the control period.
    In the past, the module would simply turn all thrusters on or off depending on baseThrustState,
    which could lead to undesired behavior because the remaining logic of the module is skipped
    (which takes into account COM offsets via the THRArrayCmdForceMsg).
    The only difference between the first and all other time steps is the unknown control period,
    so now the control period is simply set to 2 seconds for the first time step, while still
    executing the rest of the module.
    JulianHammerl authored and patkenneally committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    1716de1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dcce180 View commit details
    Browse the repository at this point in the history
  3. Update UnitTest

    JulianHammerl authored and patkenneally committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    2ed5792 View commit details
    Browse the repository at this point in the history
  4. Update documentation

    JulianHammerl authored and patkenneally committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    00e4771 View commit details
    Browse the repository at this point in the history