Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/31 continuous cm estimation #134

Merged
merged 7 commits into from
Sep 5, 2023

Conversation

rcalaon
Copy link
Collaborator

@rcalaon rcalaon commented Aug 29, 2023

  • Tickets addressed: bsk-031
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This module implements a sequential, weighted leas-squares algorithm to process torque measurements and triangulate the location of the center of mass, relying on the knowledge of the thrust vector and application point. At least two measurements are required to triangulate the location. The estimated CM location allows to stabilize the thrust vector in order to continuously dump momentum even in the presence of external disturbances such as SRP torque. Commit 1 adds a line to the cmake file to build the module in a new folder. Commit 2 adds a message containing estimated data and residuals. Commit 3 contains the initial module files. Commit 4 checks the connected messages. Commit 5 performs the actual LS estimation. Commits 6 and 7 contain the unit test and documentation, respectively.

Verification

A Unit Test is provided. Because this is an estimation, no exact result can be verified. However, this test checks the correctness of the results based on consideration regarding the estimated state error and covariance.

Documentation

Documentation is provided to explain how the estimator works.

Future work

The estimator can be expanded to include the unmodeled perturbation in the state, in order to properly estimate the CM and the unmodeled perturbation itself.

@rcalaon rcalaon added the enhancement New feature or request label Aug 29, 2023
@rcalaon rcalaon self-assigned this Aug 29, 2023
@rcalaon rcalaon linked an issue Aug 29, 2023 that may be closed by this pull request
@rcalaon rcalaon force-pushed the feature/31-continuous-CM-estimation branch 3 times, most recently from b0100c0 to 4a983c5 Compare September 1, 2023 17:29
Copy link
Collaborator

@patkenneally patkenneally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
🔻 Issues to address before merge
🔶 Requests that should not block merge, but should at least be discussed
🔵 Recommendations that can be ignored if desired

Let's have a quick chat and then this is good to pull in with minor adjustments. Nicely done!

@rcalaon rcalaon force-pushed the feature/31-continuous-CM-estimation branch from 4a983c5 to 5be052d Compare September 4, 2023 23:06
@rcalaon rcalaon force-pushed the feature/31-continuous-CM-estimation branch from 5be052d to 354107c Compare September 5, 2023 16:44
@patkenneally patkenneally merged commit 9394db7 into develop Sep 5, 2023
2 checks passed
@patkenneally patkenneally deleted the feature/31-continuous-CM-estimation branch September 5, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

thrustCMEstimation fsw module
2 participants