-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/31 continuous cm estimation #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcalaon
force-pushed
the
feature/31-continuous-CM-estimation
branch
3 times, most recently
from
September 1, 2023 17:29
b0100c0
to
4a983c5
Compare
patkenneally
requested changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legend:
🔻 Issues to address before merge
🔶 Requests that should not block merge, but should at least be discussed
🔵 Recommendations that can be ignored if desired
Let's have a quick chat and then this is good to pull in with minor adjustments. Nicely done!
src/fswAlgorithms/stateEstimation/thrustCMEstimation/thrustCMEstimation.h
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/stateEstimation/thrustCMEstimation/thrustCMEstimation.h
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/stateEstimation/thrustCMEstimation/_UnitTest/test_thrustCMEstimation.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/stateEstimation/thrustCMEstimation/thrustCMEstimation.h
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/stateEstimation/thrustCMEstimation/thrustCMEstimation.cpp
Show resolved
Hide resolved
src/fswAlgorithms/stateEstimation/thrustCMEstimation/thrustCMEstimation.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/stateEstimation/thrustCMEstimation/_UnitTest/test_thrustCMEstimation.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/stateEstimation/thrustCMEstimation/_UnitTest/test_thrustCMEstimation.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/stateEstimation/thrustCMEstimation/_UnitTest/test_thrustCMEstimation.py
Outdated
Show resolved
Hide resolved
rcalaon
force-pushed
the
feature/31-continuous-CM-estimation
branch
from
September 4, 2023 23:06
4a983c5
to
5be052d
Compare
rcalaon
force-pushed
the
feature/31-continuous-CM-estimation
branch
from
September 5, 2023 16:44
5be052d
to
354107c
Compare
patkenneally
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This module implements a sequential, weighted leas-squares algorithm to process torque measurements and triangulate the location of the center of mass, relying on the knowledge of the thrust vector and application point. At least two measurements are required to triangulate the location. The estimated CM location allows to stabilize the thrust vector in order to continuously dump momentum even in the presence of external disturbances such as SRP torque. Commit 1 adds a line to the cmake file to build the module in a new folder. Commit 2 adds a message containing estimated data and residuals. Commit 3 contains the initial module files. Commit 4 checks the connected messages. Commit 5 performs the actual LS estimation. Commits 6 and 7 contain the unit test and documentation, respectively.
Verification
A Unit Test is provided. Because this is an estimation, no exact result can be verified. However, this test checks the correctness of the results based on consideration regarding the estimated state error and covariance.
Documentation
Documentation is provided to explain how the estimator works.
Future work
The estimator can be expanded to include the unmodeled perturbation in the state, in order to properly estimate the CM and the unmodeled perturbation itself.