Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/852 simple nav gyro #227

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Conversation

thibaudteil
Copy link
Collaborator

  • Tickets addressed: bsk-852
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Update simple nav to write out the accelerometer packet message (containing acceleration and rate information). This change allows for a user to set a cadence of gyro measurements per time step (100 measurements per time step for instance) and set gyro biases and standard deviations

Verification

The unit test contains data to check the time output by the message (mean time for all the measurements) and the statistics on the noise

Documentation

Updated given new message

Future work

The module needs a healthy refactoring

Copy link
Collaborator

@codyallard28 codyallard28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we ever use omega_Dot directly from a gyro? Isn't deltaTheta and omega coming from a gyro, and then we take omega and numerically differentiate to find omegaDot? Regardless, I approve.

@patkenneally patkenneally force-pushed the feature/852-simple-nav-gyro branch 2 times, most recently from f40c9c3 to 7ed5223 Compare June 7, 2024 19:25
@patkenneally patkenneally force-pushed the feature/852-simple-nav-gyro branch 2 times, most recently from 2d42911 to 617a82e Compare June 12, 2024 21:53
Copy link
Collaborator

@patkenneally patkenneally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just spotted some additional things worth considering. We could also come back later for a large module refactor.

@thibaudteil thibaudteil force-pushed the feature/852-simple-nav-gyro branch 3 times, most recently from 50ef508 to 321aaba Compare June 17, 2024 19:18
@thibaudteil thibaudteil merged commit d2edcdc into develop Jun 18, 2024
3 checks passed
@thibaudteil thibaudteil deleted the feature/852-simple-nav-gyro branch June 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants