Fix message package __init__.py symlink overwrite #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
feature/allow-build-module-symlink-overwrite
branch
2 times, most recently
from
3e4f692
to
c9fc506
Compare
patkenneally
changed the title
brsm3129
approved these changes
Jul 24, 2024
patkenneally
force-pushed
the
feature/allow-build-module-symlink-overwrite
branch
2 times, most recently
from
b90349a
to
81f869e
Compare
The conditional is redundant because the exist_ok=True is being passed which recreates the directory even if it exists. Recreating it is inline with the rationale that the directory, the __init__ file and its contents should be recreated each build, rather than requiring a -clean which is a much more significant erasure of cached build files.
patkenneally
force-pushed
the
feature/allow-build-module-symlink-overwrite
branch
from
81f869e
to
0af142d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
generateMessagepackageInit.pyis updated to overwrite the__init__.pyfile on each build. To achieve this a customsymlinkfunction is added which overwrites the existing symlink and prevents race conditions.Verification
The build was tested by invalidating the build cache to force the build to rerun. The
__init__.pywas correctly regenerated.Documentation
None new, none invalidated.
Future work
There were a lot of potential refactors that could have hitched their wagon to this PR. However, given the substantial message system redesign coming, many of those refactors will be made redundant.