Fix Finding Extrema Functionality #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brsm3129
force-pushed
the
feature/fix-extrema-runs
branch
8 times, most recently
from
589281d
to
5df1b3c
Compare
brsm3129
force-pushed
the
feature/fix-extrema-runs
branch
from
e2ff194
to
7cdf45b
Compare
brsm3129
force-pushed
the
feature/fix-extrema-runs
branch
from
7cdf45b
to
a6d2a2f
Compare
brsm3129
commented
Jul 29, 2024
brsm3129
commented
Jul 29, 2024
brsm3129
commented
Jul 29, 2024
brsm3129
commented
Jul 29, 2024
brsm3129
added
bug
brsm3129
force-pushed
the
feature/fix-extrema-runs
branch
3 times, most recently
from
ef66360
to
88dac6b
Compare
brsm3129
force-pushed
the
feature/fix-extrema-runs
branch
2 times, most recently
from
ee006ba
to
2343b56
Compare
brsm3129
force-pushed
the
feature/fix-extrema-runs
branch
from
2343b56
to
1b635c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By associating all curves with a run number, we allow our selves to transpose the dataframe to find outliers in a time range.
Verification
Tested using the monte carlo examples
Documentation
No Documentation invalidated but getExtremaRunIndices only works with data formatted using curve_per_df_column
Future work
We would like to create a class that centralized plotting routines that standardizes all plotting for every variable.