Feature/momentum bias #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaogvcarneiro
force-pushed
the
feature/momentum_bias
branch
from
701b593
to
ded5be8
Compare
joaogvcarneiro
force-pushed
the
feature/momentum_bias
branch
from
ded5be8
to
1241866
Compare
patkenneally
requested changes
Sep 28, 2024
...fswAlgorithms/attControl/thrMomentumManagementCpp/_UnitTest/test_thrMomentumManagementCpp.py
Outdated
Show resolved
Hide resolved
...fswAlgorithms/attControl/thrMomentumManagementCpp/_UnitTest/test_thrMomentumManagementCpp.py
Outdated
Show resolved
Hide resolved
...ms/attControl/thrMomentumManagementCpp/_UnitTest/test_thrMomentumManagementCpp_integrated.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/attControl/thrMomentumManagementCpp/thrMomentumManagementCpp.h
Outdated
Show resolved
Hide resolved
joaogvcarneiro
force-pushed
the
feature/momentum_bias
branch
from
1241866
to
04f03ac
Compare
joaogvcarneiro
force-pushed
the
feature/momentum_bias
branch
3 times, most recently
from
3e9964a
to
9015cd6
Compare
patkenneally
force-pushed
the
feature/momentum_bias
branch
from
9015cd6
to
c84b17c
Compare
patkenneally
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first three commits change the source files, the next two add two new unit tests, and the last one improves the module's documentation.
Verification
Two tests are added. The first one checks the instantaneous value of the momentum management torque to check it is applied from the current to the desired rw momentum. The second is an integrated test that runs through the entire momentum dumping routine and checks that the last value of the rw momentum is close to its desired value.
Documentation
Added documentation that explains this new use case.
Future work
N/A.