Feature/update read write ck file #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaogvcarneiro
force-pushed
the
feature/update_read_write_ck_file
branch
2 times, most recently
from
a0ad3d3
to
4333ca3
Compare
thibaudteil
approved these changes
Sep 9, 2024
joaogvcarneiro
force-pushed
the
feature/update_read_write_ck_file
branch
2 times, most recently
from
6b15e7b
to
a0634cc
Compare
joaogvcarneiro
force-pushed
the
feature/update_read_write_ck_file
branch
from
a0634cc
to
a7bc353
Compare
This includes commenting the code, reshuffling the logic for some of the if statements and removing hardcoded values
joaogvcarneiro
force-pushed
the
feature/update_read_write_ck_file
branch
from
a7bc353
to
640c3c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first four commits refactor the SPICE CK routines, the fifth adds the MAVEN spacecraft spacecraft clock and the sixth adds the test file.
Verification
The test file runs a simulation, writes the rotational data to a CK file, reads it and compares the output to the original simulation data.
Documentation
No documentation is added, but a significant amount of comments are included for future developers.
Future work
Might change the routines to use
spiceypyinstead.