Migrate c modules to cpp #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
refactor/migrate-c-modules-to-cpp
branch
from
c06972c
to
a219900
Compare
patkenneally
force-pushed
the
refactor/migrate-c-modules-to-cpp
branch
6 times, most recently
from
63daed9
to
cd9c41b
Compare
patkenneally
force-pushed
the
refactor/migrate-c-modules-to-cpp
branch
3 times, most recently
from
74571a0
to
4f868a3
Compare
This is the first step to removing the C messaging infrastructure. The C++ messaging system is better fit for purpose and requires little-to-no code generation. C can always be used from C++, so this drastically reduces our exposed API surface at no cost. Co-authored-by: Jonathan Castello <[email protected]>
Co-authored-by: Jonathan Castello <[email protected]>
In addition it would seem that the recorder redirection test was pretty busted. The test is ammended and now tests correct behavior. Co-authored-by: Jonathan Castello <[email protected]>
Co-authored-by: Jonathan Castello <[email protected]>
Co-authored-by: Jonathan Castello <[email protected]>
Co-authored-by: Jonathan Castello <[email protected]>
Co-authored-by: Jonathan Castello <[email protected]>
patkenneally
force-pushed
the
refactor/migrate-c-modules-to-cpp
branch
from
9b27093
to
22891c8
Compare
patkenneally
force-pushed
the
refactor/migrate-c-modules-to-cpp
branch
from
22891c8
to
ac1ab13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first three commits of this PR are preparation for the mammoth migration of all C modules to C++.
BSKLoggerand makes the classfinal.ReadFunctor, because its pointer is at best null and at worst garbage.std::mapstatic. There was a strange and perhaps undiagnosable memory access fault seemingly involving copy/move constructors and we couldn't get to the root cause. Rather than spend excessive amounts of time, making the map static removed the potential for error.The fourth commit, migrates all C modules to C++. To quote from the associated commit message,
Subsequent commits remove all C messaging infrastructure from simulation modules, and remove all C messaging infrastructure.
Verification
All CI runs
Documentation
So much documentation was probably invalidated. This is a Future Pat task (seriously though, there is a ticket for updating this after the messaging migration).
Future work
None