Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1135 brightness increase threshold #330

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

JulianHammerl
Copy link
Collaborator

  • Tickets addressed: MAXGNC-1135
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

The centerOfBrightness module now tracks the relative change of the rolling average of the total brightness. If the relative change is above a specified threshold, the output message of the module is written as usual and with a good validity flag. If it is below the threshold, the image is invalidated and only the average brightness is written to the output message.

Verification

The UnitTest was updated accordingly.

Documentation

The rst documentation was updated.

Future work

N/A

@JulianHammerl JulianHammerl added the enhancement New feature or request label Sep 18, 2024
@JulianHammerl JulianHammerl self-assigned this Sep 18, 2024
@JulianHammerl JulianHammerl force-pushed the feature/1135-brightness-increase-threshold branch 2 times, most recently from 5c1700e to df494d6 Compare September 26, 2024 14:54
@JulianHammerl JulianHammerl force-pushed the feature/1135-brightness-increase-threshold branch from df494d6 to 0e0e541 Compare September 30, 2024 20:56
@patkenneally patkenneally force-pushed the feature/1135-brightness-increase-threshold branch from 0e0e541 to 9b7bcd8 Compare October 4, 2024 22:49
@patkenneally patkenneally merged commit 5a28ad8 into develop Oct 7, 2024
4 checks passed
@patkenneally patkenneally deleted the feature/1135-brightness-increase-threshold branch October 7, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants