Replace PR closure workflow with a common Conan cache creator #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twisol
force-pushed
the
feature/cache-conan-dependencies
branch
6 times, most recently
from
a2ea566
to
695e1ad
Compare
Twisol
force-pushed
the
feature/cache-conan-dependencies
branch
from
695e1ad
to
272d2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that, whenever a(nother) PR is merged, a new Conan dependency cache is created. While all current PRs do benefit from their own caches, these are tightly scoped and must be generated fresh at least once per PR. This workflow ensures that the
developbranch also has such a cache. New PRs will be able to load (or at least restore from) this cache, because it is on thedevelopbranch, which is (1) the base branch for most PRs (and therefore its caches are accessible to most PRs), and (2) the default branch of the repository (and therefore its caches are accessible to all PRs).This PR only adds such logic for Linux builds at the moment.
Verification
The restriction to "closed" PRs is temporarily commented out for purposes of testing this PR against the CI. It will be uncommented prior to merge, at which point we will have confidence that the workflow itself is acting as expected.
Documentation
No documentation invalidated, I think.
Future work
No specific future work, but hopefully our PRs can iterate a bit faster :)