Allow functions as dispersion variables #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
feature/allow-function-as-dispersion-variable
branch
2 times, most recently
from
bc03387
to
b834047
Compare
patkenneally
force-pushed
the
feature/allow-function-as-dispersion-variable
branch
from
b834047
to
42c16b4
Compare
thibaudteil
approved these changes
Nov 5, 2024
patkenneally
deleted the
feature/allow-function-as-dispersion-variable
branch
leahkiner
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a small adjustment to allow a function to be passed as a monte carlo dispersion string. The string is
eval'd and ifcallablethe function is called with the accompanying dispersion value as the parameter. This is a really terrible solution. However, with much of the monte carlo infrastructure being significantly refactored soon, it's a temporary blight which will be swept away by the refactor.Verification
Tested on multiple monte carlos.
Documentation
NA
Future work
NA