Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for invalid file path resolution. #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsekhan
Copy link

@tsekhan tsekhan commented Jun 21, 2019

I faced with problem that when I'm tried to measure coverage of tests ran by mocha-puppeteer with nyc (istanbul) it generates report where all files are placed in root. Also I was unable to open page with file coverage (it reports something like Unable to lookup source: PlaceholderRoles.js(ENOENT: no such file or directory, open 'PlaceholderRoles.js')).

I dug into this and found that problem comes from lasso-babel-transform.
path.relative(curDir, filename) will always return only name of file since curDir is just a folder where this file placed (see line 52).

I'm not 100% sure about proposed fix, but at least it fixed my problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant