New CredentialProvider for AWS’ credential_process facility
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 17, 2022 19:25
Mainly for meander but also to skip `comment` forms.
I’m including this here as a discrete commit mainly to facilitate better/easier peer review; this way a reviewer can diff the next commit against this one to see exactly what changes I’ve made to the copy-pasta code to adapt it to our needs. tbh this isn’t the code *verbatim* but it’s close. I made a few tweaks just so it would compile, e.g. I removed a reference to `with-system-properties` and simplified function names a bit, minor stuff like that. CETUS-61
I have no idea why the original code in the pod is retrieving the config key `credential_process` from the AWS CLI credentials file rather than the config file. In our case, wherein our profiles are created by aws-sso-util, that key is in the profile definitions in our config files. So for this to work for us, we need to retrieve this key from our config files. I suppose perhaps there are some tools/people/cases that store that key in the credentials file because I suppose the command could potentially contain sensitive strings. I guess? But why would that matter? I mean, it’s not like the credentials file is encrypted or something. Regardless, it may be the case that the key *is* sometimes stored in the credentials file, and we might want to support that case as well. TBD. CETUS-61
Re: the removed content: I suspect this is unnecessary in the root README. If someone really needs to specify a profile name programmatically, they can read the source. Or maybe they’ll just override AWS_PROFILE; that’d work just fine and shouldn’t be too tricky. CETUS-61
Automated tests coming soon! CETUS-61
ghost
self-assigned this
I started with copy-pasta of the aws-vault provider tests. Which was helpful! CETUS-61
ghost
marked this pull request as ready for review
lvh
reviewed
Apr 19, 2022
lvh
reviewed
Apr 19, 2022
lvh
reviewed
Apr 19, 2022
ghost
changed the title
CredentialProvider for AWS’ credential_process facilityCredentialProvider for AWS’ credential_process facility
lvh
reviewed
Apr 19, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CETUS-61.
This is working for me with the included manual test, when used with an AWS CLI profile created by
aws-sso-util.e.g. from the root of the repo:
CETUS-61