Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct jose_jws.3 man page example #122

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

grooverdan
Copy link
Contributor

Make the ver function in the example have the jws variable used within the function.

Copy link
Collaborator

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is changed ... should not the code be changed consequently?

I mean, change include/jose/jws.h similarly

@grooverdan
Copy link
Contributor Author

Ok. Didn't see that there too so yes, obviously should change also. Is the change right however?

@sarroutbi
Copy link
Collaborator

Ok. Didn't see that there too so yes, obviously should change also. Is the change right however?

Yes, IMHO, change LGTM

@sarroutbi
Copy link
Collaborator

sarroutbi commented Feb 10, 2023

Hello @grooverdan. May I ask you to change include/jose/jws.h similarly?

Thanks!

And the mathcing example in jws.h
@grooverdan
Copy link
Contributor Author

Apologizes for the delay, there now.

Copy link
Collaborator

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks for the PR

@sarroutbi sarroutbi merged commit ad08d70 into latchset:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants