Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKK_EC_EDWARDS: EC_PARAMS containing oID #325

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

0pq76r
Copy link

@0pq76r 0pq76r commented Dec 5, 2023

I have a token where the EC_PARAMS describe the curve using the oID as specified in RFC 8410.

I imagine that the proposed solution is fairly inefficient compared to the memcmp that is currently done for the PrintableString representation. Would you recommend to introduce new constants for the oId instead?
Or do you know of an efficient solution that supports both/all valid representations?

Support for tokens that specify Edwards curves using the oID
selection.

Signed-off-by: Florian Wernli <[email protected]>
@simo5
Copy link
Member

simo5 commented Dec 5, 2023

I think this way is just fine

@0pq76r 0pq76r marked this pull request as ready for review December 5, 2023 15:19
Copy link
Contributor

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@simo5 simo5 merged commit 412fe7c into latchset:main Dec 5, 2023
10 of 19 checks passed
@simo5
Copy link
Member

simo5 commented Dec 5, 2023

Merged, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants