Fix issues found by the last Coverity Scan check #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondřej Surý <[email protected]>
Instead of returning from p11prov_store_load() under lock if p11prov_ctx_fns() returns NULL, break from the loop to handle the error path normally. Signed-off-by: Ondřej Surý <[email protected]>
The find_keys() function could initialize the *pub and *priv key parameters while returning an error. Fix the internal logic to only set the *pub and *priv pointers on a success. While it's normally ok to expect the extra parameters to be in undefined state, at least in p11prov_store_load(), it might happen that *pub and *priv would be used later even if find_keys() returned error. Signed-off-by: Ondřej Surý <[email protected]>
|
This could be also fixed by clearing the public and private key pointers on error in the |
oerdnj
force-pushed
the
coverity-fixes-20220726
branch
from
bb6c508
to
fade462
Compare
The p11prov_debug_token_info() had CK_INFO_TOKEN structure parameter instead of the pointer to it, while relatively harmless, there was no reason why pointer to CK_INFO_TOKEN couldn't be passed. Signed-off-by: Ondřej Surý <[email protected]>
oerdnj
force-pushed
the
coverity-fixes-20220726
branch
from
fade462
to
ff32bbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.