Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let that cycle back into the provider and call C_GenerateRandom() if that's how the properties end up wiring things.
Fixes #280
Description
After some consideration I think using the openssl RAND functions is just fine here.
First of all it is not a security sensitive thing, and secondarily those functions will still cycle back to use the C_GenerateRandom function if we probed that the token does have a random generator and properties force it.
The existing generation test should eb sufficient to cover this change, and no documentation needs to be updated.
Checklist
Test suite updated with functionality testsTest suite updated with negative testsDocumentation updatedReviewer's checklist: