Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for legacy RSA_PKCS1_WITH_TLS_PADDING #402

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Add support for legacy RSA_PKCS1_WITH_TLS_PADDING #402

merged 2 commits into from
Jun 4, 2024

Conversation

simo5
Copy link
Member

@simo5 simo5 commented May 31, 2024 •
edited
Loading

Description

Obsoletes #392

Fixes #375

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@simo5
Copy link
Member Author

simo5 commented May 31, 2024

This is still missing tests, unfortunately this mode cannot be tested via the command line and will require a C test. Maybe able to contribute it next week ...

@simo5 simo5 mentioned this pull request May 31, 2024
Closed
@simo5 simo5 force-pushed the tls_padding branch 3 times, most recently from c608ab5 to 1eb8b74 Compare May 31, 2024 19:37
@simo5 simo5 added the covscan Triggers Coverity Scanner label May 31, 2024
@github-actions github-actions bot removed the covscan Triggers Coverity Scanner label May 31, 2024
@simo5 simo5 requested a review from Jakuje June 3, 2024 18:25
@simo5 simo5 force-pushed the tls_padding branch 3 times, most recently from e3bef68 to db001b2 Compare June 3, 2024 19:10
@simo5 simo5 added the covscan Triggers Coverity Scanner label Jun 3, 2024
@github-actions github-actions bot removed the covscan Triggers Coverity Scanner label Jun 3, 2024
Jakuje
Jakuje reviewed Jun 4, 2024
View reviewed changes
tests/tlsctx.c Outdated Show resolved Hide resolved
tests/tlsctx.c Show resolved Hide resolved
src/asymmetric_cipher.c Outdated Show resolved Hide resolved
@simo5 simo5 added the no-covscan-obsolete-label Do not use this label label Jun 4, 2024
@simo5 simo5 requested a review from Jakuje June 4, 2024 13:08
@simo5 simo5 added covscan-ok Coverity scan passed and removed no-covscan-obsolete-label Do not use this label labels Jun 4, 2024
Jakuje
Jakuje approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@simo5 simo5 merged commit b356c0e into latchset:main Jun 4, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakuje Jakuje Jakuje approved these changes

Assignees
No one assigned
Labels
covscan-ok Coverity scan passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RSA_PKCS1_WITH_TLS_PADDING functionality implemented
2 participants
@simo5 @Jakuje