Rsa keygen #56
Merged
Rsa keygen #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
force-pushed
the
rsa_keygen
branch
2 times, most recently
from
0aebcd2
to
b8bdb2a
Compare
|
@fabled I gave another spin to the old rsa_keygen patch, this one is based on the session_obj PR |
This also adds the ability to require a logged in slot at the same time which is normally needed for operations that want to use a private key. Signed-off-by: Simo Sorce <[email protected]>
simo5
force-pushed
the
rsa_keygen
branch
3 times, most recently
from
428cdd2
to
beae87b
Compare
Add RSA private key generation code Generalize keymgmt dispatch helpers Make some fuctions more generic Add basic EC genkey support Signed-off-by: Simo Sorce <[email protected]>
simo5
force-pushed
the
rsa_keygen
branch
2 times, most recently
from
d28ad60
to
59530c3
Compare
Signed-off-by: Simo Sorce <[email protected]>
Only really prints key info when utils like openssl genpkey are given options like -text For pem or der format it currently returns error on selection and specify null functions for encoders. Signed-off-by: Simo Sorce <[email protected]>
|
I think this is good enough for now, merging |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to implement RSA key generation function as best we can.
openssl genpkey assumes that you always have key data to return, which is obviously not the case when generateing a key on a token.
We provide a function to print the -text option, but errors are reported from the missing pem/der encoding functions although public and private keys are generated and stored in the DB.
A separate test binary checks that we can correctly generate keys and apply ID and Label to them.