Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for \LTcaptype, issue #1377 #1398

Merged
merged 1 commit into from
Jul 6, 2024
Merged

add support for \LTcaptype, issue #1377 #1398

merged 1 commit into from
Jul 6, 2024

Conversation

u-fischer
Copy link
Member

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • Rollback provided (if necessary)? Imho not needed
  • ltnewsX.tex (and/or latexchanges.tex) updated

josephwright
josephwright reviewed Jul 6, 2024
View reviewed changes
required/tools/longtable.dtx
Comment on lines +934 to +935
% The name used as counter, in caption, "\addcontentsline" and in targets.
% "\providecommand" is used for compability with \pkg{ltcaption}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically use "|"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephwright not my fault ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longtable predates latex2e:-) it has % \DeleteShortVerb{\|} (it has several fragments that want a verbatim |)

@davidcarlisle davidcarlisle merged commit 7c96b6b into develop Jul 6, 2024
82 checks passed
@davidcarlisle davidcarlisle deleted the gh1377-longtable branch July 6, 2024 08:25
muzimuzhi added a commit to muzimuzhi/latex2e that referenced this pull request Jul 6, 2024
@muzimuzhi
Correct typos introduced in latex3#1398
e770b71 
And reformat longtable.dtx.
davidcarlisle pushed a commit that referenced this pull request Jul 8, 2024
@muzimuzhi
Correct typos introduced in gh1398 and gh1401 (#1402)
eebb4ea 
* Correct typos introduced in #1401

* Correct typos introduced in #1398

And reformat longtable.dtx.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephwright josephwright josephwright approved these changes

@davidcarlisle davidcarlisle davidcarlisle approved these changes

@FrankMittelbach FrankMittelbach Awaiting requested review from FrankMittelbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@u-fischer @josephwright @davidcarlisle