Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: DRY metadata hook #222

Merged
merged 1 commit into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
'use client'

import { Suspense, useCallback, useEffect, useMemo, useState } from 'react'
import { Suspense, useCallback, useMemo, useState } from 'react'

import { ConversationMetadata, readMetadata } from '@latitude-data/compiler'
import { promptConfigSchema } from '@latitude-data/core/browser'
import {
Button,
DocumentTextEditor,
DocumentTextEditorFallback,
} from '@latitude-data/web-ui'
import EditorHeader from '$/components/EditorHeader'
import { useMetadata } from '$/hooks/useMetadata'
import useEvaluations from '$/stores/evaluations'
import useProviderApiKeys from '$/stores/providerApiKeys'

Expand All @@ -30,11 +30,16 @@ export default function EvaluationEditor({
)
const { data: providers } = useProviderApiKeys()
const [value, setValue] = useState(defaultPrompt)
const [metadata, setMetadata] = useState<ConversationMetadata>()
const configSchema = useMemo(
() => promptConfigSchema({ providers: providers ?? [] }),
[providers],
)
const { metadata } = useMetadata({
prompt: value,
withParameters: EVALUATION_PARAMETERS,
configSchema,
})

const save = useCallback(
(val: string) => {
update({
Expand All @@ -52,14 +57,6 @@ export default function EvaluationEditor({
[setValue],
)

useEffect(() => {
readMetadata({
prompt: value,
withParameters: EVALUATION_PARAMETERS,
configSchema,
}).then(setMetadata)
}, [value, configSchema])

if (!evaluation) return null

return (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,9 @@
'use client'

import path from 'path'
import {
createContext,
Suspense,
useCallback,
useEffect,
useMemo,
useState,
} from 'react'
import { createContext, Suspense, useCallback, useMemo, useState } from 'react'

import {
ConversationMetadata,
readMetadata,
Document as RefDocument,
} from '@latitude-data/compiler'
import { Document as RefDocument } from '@latitude-data/compiler'
import {
DocumentVersion,
promptConfigSchema,
Expand All @@ -28,6 +17,7 @@ import {
import { type AddMessagesActionFn } from '$/actions/sdk/addMessagesAction'
import type { RunDocumentActionFn } from '$/actions/sdk/runDocumentAction'
import EditorHeader from '$/components/EditorHeader'
import { useMetadata } from '$/hooks/useMetadata'
import useDocumentVersions from '$/stores/documentVersions'
import useProviderApiKeys from '$/stores/providerApiKeys'
import { useDebouncedCallback } from 'use-debounce'
Expand Down Expand Up @@ -68,11 +58,6 @@ export default function DocumentEditor({
)
const [value, setValue] = useState(document.content)
const [isSaved, setIsSaved] = useState(true)
const [metadata, setMetadata] = useState<ConversationMetadata>()
const configSchema = useMemo(
() => promptConfigSchema({ providers }),
[providers],
)

const debouncedSave = useDebouncedCallback(
(val: string) => {
Expand Down Expand Up @@ -128,14 +113,17 @@ export default function DocumentEditor({
[readDocumentContent, value],
)

useEffect(() => {
readMetadata({
prompt: value,
fullPath: document.path,
referenceFn: readDocument,
configSchema,
}).then(setMetadata)
}, [readDocument, configSchema])
const configSchema = useMemo(
() => promptConfigSchema({ providers }),
[providers],
)

const { metadata } = useMetadata({
prompt: value,
fullPath: document.path,
referenceFn: readDocument,
configSchema,
})

const isMerged = commit.mergedAt !== null
return (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
'use client'

import { useCallback, useEffect, useState } from 'react'
import { useCallback } from 'react'

import { ConversationMetadata, readMetadata } from '@latitude-data/compiler'
import { DocumentVersion, EvaluationDto } from '@latitude-data/core/browser'
import { Button, CloseTrigger, Modal } from '@latitude-data/web-ui'
import { useMetadata } from '$/hooks/useMetadata'
import { useNavigate } from '$/hooks/useNavigate'
import { ROUTES } from '$/services/routes'

Expand Down Expand Up @@ -42,13 +42,11 @@ export default function CreateBatchEvaluationModal({
goToDetail()
},
})
const [metadata, setMetadata] = useState<ConversationMetadata>()
useEffect(() => {
readMetadata({
prompt: document.content ?? '',
fullPath: document.path,
}).then(setMetadata)
}, [document])

const { metadata } = useMetadata({
prompt: document.content ?? '',
fullPath: document.path,
})

const form = useRunBatchForm({ documentMetadata: metadata })
const onRunBatch = useCallback(() => {
Expand Down
18 changes: 18 additions & 0 deletions apps/web/src/hooks/useMetadata.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { useEffect, useState } from 'react'

import { ConversationMetadata, readMetadata } from '@latitude-data/compiler'

type Props = Parameters<typeof readMetadata>[0]
export function useMetadata(props: Props) {
const [isLoading, setIsLoading] = useState(true)
const [metadata, setMetadata] = useState<ConversationMetadata>()
useEffect(() => {
setIsLoading(true)
readMetadata(props).then((m) => {
setMetadata(m)
setIsLoading(false)
})
}, [props])

return { metadata, isLoading }
}
Loading