Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gas-report): run gas report with --isolate #2331

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

holic
Copy link
Member

@holic holic commented Feb 28, 2024

Copy link

changeset-bot bot commented Feb 28, 2024

🦋 Changeset detected

Latest commit: 9ef35f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/gas-report Major
@latticexyz/cli Major
@latticexyz/schema-type Major
@latticexyz/store Major
@latticexyz/world-modules Major
@latticexyz/world Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/dev-tools Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/react Major
@latticexyz/recs Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review March 5, 2024 10:53
@holic
Copy link
Member Author

holic commented Mar 5, 2024

based on https://twitter.com/gakonst/status/1764118290715304214, going to consider this a better picture of gas usage for our tests and suggest we ship this

@holic holic changed the title test: run gas report with --isolate feat(gas-report): run gas report with --isolate Mar 5, 2024
Copy link
Contributor

@yonadaaa yonadaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! some big increases

@holic holic merged commit 90d0d79 into main Mar 5, 2024
12 checks passed
@holic holic deleted the holic/gas-report-isolate branch March 5, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants