Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resume read_package after drop. #915

Closed
wants to merge 4 commits into from
Closed

Resume read_package after drop. #915

wants to merge 4 commits into from

Commits on Dec 29, 2020

  1. Run format missing in master

    @antialize
    antialize committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    e2241e3 View commit details
    Browse the repository at this point in the history

  2. Test dropping of mysql connections during read. 

    Currently there is a bug in this part of the code, but it is hard to reliability tricker.
The man problem with trickering the test seems to be that sqlx_rt::timeout is not very
precise under async std, and straight up broken in tokio.

On my box, the test fails around half the time when using tokio, and almost
always when using async std
    @antialize
    antialize committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    d4dad47 View commit details
    Browse the repository at this point in the history

  3. Add forwarding read_some method

    @antialize
    antialize committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    31ad378 View commit details
    Browse the repository at this point in the history

  4. mysql: Resume read_package after drop. 

    This fixes #563

Data read from a mysql stream is ultimitly read by read_package.
If the read package future is droped before it is done, it will
leave the stream in an invalid state. To fix this we store the state of the read_package
future in the stream it self such that read_package just resumens reading the same
package it is called again after beeing dropped
    @antialize
    antialize committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    8092411 View commit details
    Browse the repository at this point in the history