Handle dropping wait_for_conn #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If wait_for_conn is dropped before completing, release will call wake on a waker that noone is listining on. This leads to a state where waiting will gro indefinitly while all connections are idle. To fix this we turn waiting into a queue of unique Weak pointers. This way if wait_for_conn is dropped the pointer in waiting cannot be upgraded, we can use this as a signal that we shoud wake the next one instead.
|
We have a pending rewrite of the pool implementation that fixed this by replacing the In the meantime, this is a perfectly good fix that we can put out in a patch release. Thanks. |
|
Curious if there's a timeline for a patch release with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If wait_for_conn is dropped before completing, release will call
wake on a waker that no one is listening on. This leads to a state where
waiting will grow indefinitely while all connections are idle.
To fix this we turn waiting into a queue of unique Weak pointers.
This way if wait_for_conn is dropped the pointer in waiting cannot
be upgraded, we can use this as a signal that we shroud wake the
next one instead.
We get into a similar state will happen if wait_for_conn timeouts.