Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add observer to the SDK's gemspec to avoid warnings in ruby 3.3/support ruby 3.4 #271

Closed
dgollahon opened this issue Apr 24, 2024 · 3 comments · Fixed by #272 or #273
Closed

Add observer to the SDK's gemspec to avoid warnings in ruby 3.3/support ruby 3.4 #271

dgollahon opened this issue Apr 24, 2024 · 3 comments · Fixed by #272 or #273

Comments

@dgollahon
Copy link

Describe the bug
I get the following warning in ruby 3.3.1 using sdk version 7.2.0 (but looks to still apply on master):

warning: [...]/lib/ruby/3.3.0/observer.rb was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add observer to your Gemfile or gemspec. Also contact author of launchdarkly-server-sdk-7.2.0 to add observer into its gemspec.

To reproduce
Require the gem with $VERBOSE = true on ruby 3.3.x

Expected behavior
No warnings are emitted.

Logs
N/A

SDK version
7.2.0

Language version, developer tools
Ruby 3.3.1

OS/platform
MacOS

Additional context
N/A
@keelerm84
Copy link
Member

Thank you for bringing this to our attention. I will make sure it gets addressed soon and will let you know once it has been resolved.

keelerm84 added a commit that referenced this issue Apr 29, 2024
@keelerm84
fix: Add observer as explicit dependency
1bc8652 
Fixes #271
@keelerm84 keelerm84 mentioned this issue Apr 29, 2024
Merged
keelerm84 added a commit that referenced this issue Apr 29, 2024
@keelerm84
fix: Add observer as explicit dependency (#272)
f2226a6 
Fixes #271
@github-actions github-actions bot mentioned this issue Apr 29, 2024
Merged
keelerm84 pushed a commit that referenced this issue Apr 29, 2024
@github-actions
chore(main): release 8.4.1 (#273)
caead08 
🤖 I have created a release *beep* *boop*
---


##
[8.4.1](8.4.0...8.4.1)
(2024-04-29)


### Bug Fixes

* Add observer as explicit dependency
([#272](#272))
([f2226a6](f2226a6)),
closes
[#271](#271)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@keelerm84
Copy link
Member

This has been resolved in 8.4.1

@dgollahon
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@keelerm84 @dgollahon