Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkbox UL rendering issue #11060

Closed
wants to merge 1 commit into from
Closed

Conversation

nirzaf
Copy link

@nirzaf nirzaf commented Sep 16, 2024

Fixes #11059

Fix the markdown parser to correctly render normal UL and Checkbox UL separately.

  • Assets/TinyMCE/JoplinLists/src/main/ts/core/NormalizeLists.ts

    • Add isCheckboxList function to check if a list is a checkbox list.
    • Modify normalizeLists to handle checkbox lists separately.
  • Assets/TinyMCE/JoplinLists/src/main/ts/listModel/JoplinListUtil.ts

    • Correct typo in findContainerListTypeFromElement function.
    • Ensure findContainerListTypeFromElement correctly identifies checkbox lists.
  • Assets/TinyMCE/JoplinLists/src/main/ts/listModel/ParseLists.ts

    • Import isCheckboxListItem from JoplinListUtil.
    • Update parseLists to handle checkbox lists separately and set the correct list type.

Fixes laurent22#11059

Fix the markdown parser to correctly render normal UL and Checkbox UL separately.

* **Assets/TinyMCE/JoplinLists/src/main/ts/core/NormalizeLists.ts**
  - Add `isCheckboxList` function to check if a list is a checkbox list.
  - Modify `normalizeLists` to handle checkbox lists separately.

* **Assets/TinyMCE/JoplinLists/src/main/ts/listModel/JoplinListUtil.ts**
  - Correct typo in `findContainerListTypeFromElement` function.
  - Ensure `findContainerListTypeFromElement` correctly identifies checkbox lists.

* **Assets/TinyMCE/JoplinLists/src/main/ts/listModel/ParseLists.ts**
  - Import `isCheckboxListItem` from `JoplinListUtil`.
  - Update `parseLists` to handle checkbox lists separately and set the correct list type.
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@laurent22
Copy link
Owner

Hello, thank you for the PR. We also need test units for it

@laurent22
Copy link
Owner

Hello, I'm closing the PR for now, but please let me know if you would like to continue working on it

@laurent22 laurent22 closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants