Desktop,Cli: Fixes #8788: Work around WebDAV sync issues over ipv6 #9286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V1ck3s
approved these changes
Nov 13, 2023
packages/lib/BaseApplication.ts
Outdated
Comment on lines
640
to
644
| // Work around issues with ipv6 resolution | ||
| // (possibly incorrect URL serialization see https://github.com/mswjs/msw/issues/1388#issuecomment-1241180921). | ||
| // See also https://github.com/node-fetch/node-fetch/issues/1624#issuecomment-1407717012 | ||
| dns.setDefaultResultOrder('ipv4first'); | ||
|
|
There was a problem hiding this comment.
We might want to add an option to disable this — setDefaultResultOrder has a higher precedence than NODE_OPTIONS and users could previously enable/disable this with NODE_OPTIONS=--dns-result-order=verbatim or NODE_OPTIONS=--dns-result-order=ipv4first.1
Edit: It seems that Electron also accepts --dns-result-order=verbatim and --dns-result-order=ipv4first.
Footnotes
There was a problem hiding this comment.
The pull request has been updated to not override the default result order if --dns-result-order=something is specified on the command line.
|
Does this means that webdav sync will not work over ipv6 only network? Or will it use ipv6 normally after trying ipv4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should fix a WebDAV sync issue by restoring a network resolution behavior from Node 16 (defaulting to ipv4).
May fix #8788.
Notes
Testing
While I have verified that I can still sync to DropBox and a locally-hosted Joplin Server, this is mostly untested.