Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lava-dnf on Loihi 2 #31

Merged
merged 35 commits into from
Oct 25, 2022
Merged

Lava-dnf on Loihi 2 #31

merged 35 commits into from
Oct 25, 2022

Conversation

SveaMeyer13
Copy link
Contributor

@SveaMeyer13 SveaMeyer13 commented Oct 21, 2022 •
edited by mathisrichter
Loading

This PR adds support for running lava-dnf on Loihi 2. All code is compatible with the most recent versions of lava and lava-on-loihi (respective main branches).

Summary of relevant changes, ordered by priority for review:

mathisrichter and others added 30 commits January 11, 2022 18:48
@mathisrichter
Fixed unit tests that were accessing the now removed 'current_ts' mem…
ac57744 
…ber of Runtime.

Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Fixed deprecation warnings.
eb9c58e 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Merge branch 'deprecation_warnings_21' into interim_release
43a4f00
@mathisrichter
Merge branch 'fix_unit_tests' into interim_release
90e3da9
@mathisrichter
Updating to lava version 0.3.0 (wip)
02ea20f 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Fixed some unit tests when adapting to Lava 0.4.0.
3eefed0 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Fixed remaining failing unit tests that relied on RateCodeSpikeGen.
5204e96 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Fixed unit and integration tests.
32e3d28 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Initial integration test for a DNF on Loihi (wip).
7d07447 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
DNF on Loihi unit test (wip).
6dfed65 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Debugging tutorial for DNF regimes on Loihi (wip).
89b6cf3 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Weirdness (wip).
e005da8 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Cleaned up unit test for DNF on Loihi.
7e6353d 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Unit test for 1D DNF on Loihi 2 is passing.
e1c6fc2 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Added unit tests for 2D and 3D DNFs on Loihi 2.
69fab96 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Cleaned up test script for DNF-regimes tutorial.
1b8011e 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Fixed errors in docstrings.
7142a6e 
Signed-off-by: Mathis Richter <[email protected]>
@SveaMeyer13
update loihi tutorial
3a6a3b3
@SveaMeyer13
remove output
92e908f
@SveaMeyer13
eliminate sum process
b6b3763
@mathisrichter
Merge pull request lava-nc#1 from SveaMeyer13/tutorials-on-loihi
1d790b4 
Add Loihi 2 Tutorials
@mathisrichter
Adding empty lines at the end
6b214be 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Merge branch 'main' of https://github.com/lava-nc/lava-dnf into dnf_o…
090b6d9 
…n_loihi

� Conflicts:
�	src/lava/lib/dnf/inputs/rate_code_spike_gen/models.py
�	tests/lava/lib/dnf/acceptance/test_connecting_with_ops.py
�	tests/lava/lib/dnf/acceptance/test_gauss_spike_generator.py
�	tests/lava/lib/dnf/inputs/gauss_pattern/test_process.py
�	tests/lava/lib/dnf/inputs/rate_code_spike_gen/test_models.py
�	tests/lava/lib/dnf/inputs/rate_code_spike_gen/test_process.py
�	tutorials/lava/lib/dnf/dnf_101/tutorial_dnf_101.ipynb
�	tutorials/lava/lib/dnf/dnf_regimes/tutorial_dnf_regimes.ipynb
�	tutorials/lava/lib/dnf/dnf_regimes/utils.py
�	tutorials/lava/lib/dnf/relational_networks/tutorial_relational_networks.ipynb
@SveaMeyer13
update tutorials
7d29159
@SveaMeyer13
add 101 tutorial
045e016
@SveaMeyer13
remove transpose in utils
b5af4d8
@SveaMeyer13
remove unnecessary files
d80fa87
@SveaMeyer13
fix typo in dnf_101
9dcb243
@SveaMeyer13
remove warnings
57b3ab5
@SveaMeyer13
remove unit test on loihi 2
c842696
@mgkwill mgkwill marked this pull request as ready for review October 21, 2022 21:52
@mathisrichter
Merge branch 'main' of https://github.com/lava-nc/lava-dnf into tutor…
6eecdaf 
…ials-on-loihi
@mathisrichter
Adding PyCharm changes to tutorials to be able to merge.
530ee9d 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Merge branch 'tutorials-on-loihi' of https://github.com/SveaMeyer13/l…
25df60e 
…ava-dnf into tutorials-on-loihi

� Conflicts:
�	tutorials/lava/lib/dnf/dnf_regimes/tutorial_dnf_regimes.ipynb
�	tutorials/lava/lib/dnf/relational_networks/tutorial_relational_networks.ipynb
@mathisrichter
Fixed typo in unit test name.
5a96c7c 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter mathisrichter added the 1-feature New feature or request label Oct 22, 2022
@mathisrichter mathisrichter removed their request for review October 24, 2022 20:06
@mathisrichter
Copy link
Contributor

mathisrichter commented Oct 24, 2022 •
edited
Loading

I should not review this as I worked on most of this code together with Svea.

bamsumit
bamsumit approved these changes Oct 24, 2022
View reviewed changes
Copy link

@bamsumit bamsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at the notebooks carefully. Looks in great shape.

tests/lava/lib/dnf/inputs/rate_code_spike_gen/test_process.py Outdated Show resolved Hide resolved
@mathisrichter mathisrichter merged commit 4e32bc9 into lava-nc:main Oct 25, 2022
@mathisrichter mathisrichter mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathisrichter mathisrichter mathisrichter left review comments

@PhilippPlank PhilippPlank PhilippPlank approved these changes

@bamsumit bamsumit bamsumit approved these changes

@tim-shea tim-shea Awaiting requested review from tim-shea

@GaboFGuerra GaboFGuerra Awaiting requested review from GaboFGuerra

Assignees

@mathisrichter mathisrichter

@SveaMeyer13 SveaMeyer13

Labels
1-feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SveaMeyer13 @mathisrichter @bamsumit @PhilippPlank