Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cost tracking with Loihi backend #212

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

AlessandroPierro
Copy link
Collaborator

@AlessandroPierro AlessandroPierro commented Apr 24, 2023

Issue Number: Closes #185

Objective of pull request: enable cost tracking for OptimizationSolver on Loihi backkend

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Feature

What is the current behavior?

  • Cost tracking not enabled for Neurocore backend

What is the new behavior?

  • Cost tracking enabled for Neurocore backend through the probe_cost variable of SolverConfig

Does this introduce a breaking change?

  • No

@AlessandroPierro AlessandroPierro added the 1-feature New feature or request label Apr 24, 2023
@AlessandroPierro AlessandroPierro self-assigned this Apr 24, 2023
@AlessandroPierro AlessandroPierro marked this pull request as ready for review April 24, 2023 13:57
Copy link
Collaborator

@GaboFGuerra GaboFGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alessandro!

@AlessandroPierro AlessandroPierro changed the base branch from main to develop April 24, 2023 14:42
@AlessandroPierro AlessandroPierro merged commit c6bbcd0 into develop Apr 24, 2023
@AlessandroPierro AlessandroPierro deleted the cost-tracking-loihi branch April 24, 2023 14:43
AlessandroPierro added a commit that referenced this pull request May 3, 2023
…217)

* Enable cost tracking with Loihi backend (#212)

* Refactor solution readout by method extraction.

Signed-off-by: GaboFGuerra <[email protected]>

* Enable probing of variable assignment on OptimizationSolver.

Signed-off-by: GaboFGuerra <[email protected]>

* Bugfix in SolutionReadout pymodel

* Fix linting issues

* Add test for state tracking on OptimizationSolver

* Improve OptimizationSolver unittests

* Bugfix in OptimizationSolver unittest

* Bugfix in OptimizationSolver unittest

* Update OptimizationSolver to rtack live cost

* Bugfix in OptimizationSolver and linting issues

* Update poetry.lock

* Add decoding step in state tracking

* Refactor to consolidate cost/state decoding

* Fix linting issues

---------

Signed-off-by: GaboFGuerra <[email protected]>
Co-authored-by: GaboFGuerra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable continuous cost tracking on Loihi
2 participants