Connection tutorial finished #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippPlank
requested review from
mgkwill,
mathisrichter,
awintel and
phstratmann
awintel
approved these changes
Nov 26, 2021
There was a problem hiding this comment.
Looks fine for the release. Perhaps just fix a few typos here and there.
Generally, you should come back and improve the narrative of the tutorial a bit. It's not so valuable to just say in English what the code already does. Use English to explain the intent of why you do what you do or explain relevant architectural aspects along the way.
Right now this tutorial does not much deeper than what I will be talking about in the 'tour through lava' tutorial. Once the different PyPorts and VirtualPorts are working, we should actually go deeper on them in this tutorial.
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* modified connection tutorial for release 0.2.0 * fixed typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified connection tutorial (tutorial05_connect_processes.ipynb) for releasing.