Virtual ports no longer block Process discovery in compiler #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e compiler. Signed-off-by: Mathis Richter <[email protected]>
mathisrichter
requested review from
mgkwill,
joyeshmishra,
PhilippPlank and
awintel
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
mgkwill
approved these changes
Mar 3, 2022
joyeshmishra
approved these changes
Mar 3, 2022
|
Thanks for the quick fix @mathisrichter |
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
) * Fixing lava-nc#210, where virtual ports block Process discovery in the compiler. * Fixing possible race condition in unit test Signed-off-by: Mathis Richter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #210
Objective of pull request: Networks of Processes that contain virtual ports could only be run successfully from those Processes in the network that were "downstream" of virtual ports.
Pull request checklist
Your PR fulfills the following requirements:
pyb) passes locallypyb -E unit) or (python -m unittest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information