Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pybuilder, Add poetry #215

Merged
merged 45 commits into from
Mar 8, 2022
Merged

Remove pybuilder, Add poetry #215

merged 45 commits into from
Mar 8, 2022

Conversation

mgkwill
Copy link
Contributor

@mgkwill mgkwill commented Mar 7, 2022 •
edited
Loading

Issue Number: #217

Objective of pull request: Remove pybuilder and add build tool poetry

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit) passes locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Build related changes
  • Documentation changes

What is the current behavior?

  • pybuilder has some bugs and does not currently support editable install on Windows and running unit tests on any OS due to some virtual environment issues that are hard to pin down. The community that runs pybuilder is small and they seem less open to fix bugs when reported (I've seen bugs that reference above issue that were turned down). The result is a decision to remove pybuilder as the build agent and replace it with poetry, flakeheaven and pytest and use a central pyproject.toml as the configuration source for builds and QA tools.

What is the new behavior?

  • Poetry, flakeheaven and pytest are in use, configured with a central pyproject.toml for builds and QA tools. Docs are updated to reflect new tools.

Does this introduce a breaking change?

  • No

@mgkwill mgkwill changed the title Remove pybuilder Remove pybuilder, Add poetry Mar 7, 2022
@mgkwill mgkwill self-assigned this Mar 8, 2022
@mgkwill mgkwill added 1-bug Something isn't working documentation Improvements or additions to documentation 1-feature New feature request integration build, testing, packaging issue labels Mar 8, 2022
@mgkwill mgkwill linked an issue Mar 8, 2022 that may be closed by this pull request
Use new project build tool poetry #217
Closed
4 tasks
@mgkwill mgkwill merged commit 46ad705 into main Mar 8, 2022
@mgkwill mgkwill deleted the change-from-pyb branch March 8, 2022 00:13
@mgkwill mgkwill linked an issue Mar 9, 2022 that may be closed by this pull request
Fix install issues in readme #203
Closed
3 tasks
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@mgkwill
Remove pybuilder, Add poetry (lava-nc#215)
fa1668d 
* Remove pybuilder, use flakeheaven, bandit

* Delete build.py

* Delete requirements.txt

* Delete build-requirements.txt

* Delete setup.py

* Add poetry

* Update pyproject.toml

* Create poetry.lock

* Run unit tests with pytest

Run unit tests with pytest using config in pyproject.toml

* Update ci-build.yml

* Rename CI jobs

* Update mnist.py

* Update README.md

* Update PULL_REQUEST_TEMPLATE.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgkwill mgkwill

Labels
1-bug Something isn't working 1-feature New feature request documentation Improvements or additions to documentation integration build, testing, packaging issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use new project build tool poetry Fix install issues in readme
1 participant
@mgkwill