Enable RefPort connections #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added var_ports to compile_proc_models -channels are now also build for RefPort -> VarPort connections -added unit tests
awintel
reviewed
Nov 3, 2021
…stinctly and to throw an error if a naming conflict with an existing attribute still occurs -added unit tests for VarPorts -added _get_port_dtype(..) to compiler, to get the d_type of a Port and handle implicitly created VarPorts and throw an error if the corresponding ProcessModel does not know the Port -added unit test - modified PortInitializer to expect type "type" instead of "intc"
|
Source now moved from /lava to /src/lava. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-added RefPorts and VarPorts to find_processes
-added var_ports to compile_proc_models
-channels are now also build for RefPort -> VarPort connections
-added unit tests
Next step is to add RefPorts in the synchronization protocol to allow sending data.