Fix for dangling ports #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sistent behavior Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
… python versions. Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
bamsumit
requested review from
joyeshmishra,
mathisrichter,
PhilippPlank and
GaboFGuerra
8 tasks
mathisrichter
requested changes
Jul 21, 2022
Yeah I was looking at the best place to add that. I am not convinced it should go in |
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
mathisrichter
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Nice! I think the unit test is fine there. Since it is a feature of the compiler, you could also have written it as a part of the Compiler tests and only tested the contents of the builders, for instance. But this is also nice, then we have a working example. :)
Signed-off-by: bamsumit <[email protected]>
PhilippPlank
approved these changes
Jul 22, 2022
mgkwill
approved these changes
Jul 22, 2022
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* update refport unittest to always wait when it writes to port for consistent behavior Signed-off-by: bamsumit <[email protected]> * Removed pyproject changes Signed-off-by: bamsumit <[email protected]> * Fix to convolution tests. Fixed imcompatible mnist_pretrained for old python versions. Signed-off-by: bamsumit <[email protected]> * Dangling port fix update Signed-off-by: bamsumit <[email protected]> * Fix dangling port without breaking channel map unittests Signed-off-by: bamsumit <[email protected]> * Remove unnecessary hack for dangling port in tutorial06 Signed-off-by: bamsumit <[email protected]> * Added dangling port unittests Signed-off-by: bamsumit <[email protected]> * Linting fix Signed-off-by: bamsumit <[email protected]> * Typo fixes Signed-off-by: bamsumit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: 246
Objective of pull request:
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information