Added a compilation order heuristic for compiling C before Nc processes #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Risbud, Sumedh <[email protected]>
…Groups containing C and Nc Processes Signed-off-by: Risbud, Sumedh <[email protected]>
…Groups containing C and Nc Processes Signed-off-by: Risbud, Sumedh <[email protected]>
…lava into c_nc_compile_heuristic
Signed-off-by: Risbud, Sumedh <[email protected]>
PhilippPlank
approved these changes
Jul 22, 2022
mgkwill
approved these changes
Jul 27, 2022
mgkwill
approved these changes
Jul 27, 2022
|
Please disregard my review. |
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
…es (lava-nc#275) * DiGraphBase: collapse a cycle of length 1 correctly. Signed-off-by: Risbud, Sumedh <[email protected]> * Added 'C-first-Nc-second compilation heuristic for heterogeneous ProcGroups containing C and Nc Processes Signed-off-by: Risbud, Sumedh <[email protected]> * Bugfix to C-first-Nc-second heuristic Signed-off-by: Risbud, Sumedh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This heuristic takes effect only when both C and Nc Processes belong to the same ProcGroup
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type: