Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique process models in process models discovery #277

Merged
merged 20 commits into from
Jul 22, 2022

Conversation

bamsumit
Copy link
Contributor

Issue Number: 276

Objective of pull request:
Unique process models in process model discovery

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • Sometimes process model discovery results in repeated process model entries in process_models list.

What is the new behavior?

  • process_models list is unique

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
@bamsumit bamsumit requested a review from mgkwill July 22, 2022 20:00
@mgkwill mgkwill merged commit 7ad8e48 into lava-nc:main Jul 22, 2022
@bamsumit bamsumit deleted the netx_fixes branch July 22, 2022 20:56
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* Unique process models in process models discovery

Signed-off-by: bamsumit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants