Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default sync domain not splitting processes according to the Node #286

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Fix default sync domain not splitting processes according to the Node #286

merged 4 commits into from
Jul 29, 2022

Conversation

ysingh7
Copy link
Contributor

@ysingh7 ysingh7 commented Jul 28, 2022

Issue Number:

Objective of pull request: Fixes issue of default sync domain not splitting processes according to the Node.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • [ x] PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • [ x] Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@ysingh7 ysingh7 requested review from mgkwill and bamsumit July 28, 2022 21:40
bamsumit
bamsumit approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@bamsumit bamsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Yash

@mgkwill mgkwill changed the title Sd hp Default sync domain not splitting processes according to the Node Jul 29, 2022
@mgkwill mgkwill changed the title Default sync domain not splitting processes according to the Node Fix default sync domain not splitting processes according to the Node Jul 29, 2022
@mgkwill mgkwill added the 1-bug Something isn't working label Jul 29, 2022
@mgkwill mgkwill merged commit 1700dec into main Jul 29, 2022
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@ysingh7
Fix default sync domain not splitting processes according to the Node (…
4f3ccd3 
…lava-nc#286)

* Fixed the issue with the sync domain of hierarichal process

* Changed the implementation of splitting of sync domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgkwill mgkwill mgkwill approved these changes

@bamsumit bamsumit bamsumit approved these changes

Assignees
No one assigned
Labels
1-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ysingh7 @mgkwill @bamsumit