Messaging refactor develop #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. message_infrastructure_logging.h: logging for development 2. abstract_actor.h&posix_actor.cc: achieve stop function for signal 3. shm.h: Add SharedMemoryManager to cpplib 4. others: Update CMake, test and fix some type error' fix pylint error
killight98
requested changes
Aug 16, 2022
src/lava/magma/runtime/message_infrastructure/message_infrastructure/multiprocessing.py
Outdated
Show resolved
Hide resolved
src/lava/magma/runtime/message_infrastructure/message_infrastructure/multiprocessing.py
Outdated
Show resolved
Hide resolved
src/lava/magma/runtime/message_infrastructure/message_infrastructure/multiprocessing.py
Outdated
Show resolved
Hide resolved
killight98
requested changes
Aug 16, 2022
src/lava/magma/runtime/message_infrastructure/message_infrastructure/multiprocessing.py
Outdated
Show resolved
Hide resolved
killight98
requested changes
Aug 16, 2022
src/lava/magma/runtime/message_infrastructure/message_infrastructure/multiprocessing.py
Outdated
Show resolved
Hide resolved
src/lava/magma/runtime/message_infrastructure/message_infrastructure/csrc/multiprocessing.h
Outdated
Show resolved
Hide resolved
killight98
requested changes
Aug 16, 2022
src/lava/magma/runtime/message_infrastructure/message_infrastructure/multiprocessing.py
Show resolved
Hide resolved
src/lava/magma/runtime/message_infrastructure/message_infrastructure/multiprocessing.py
Outdated
Show resolved
Hide resolved
src/lava/magma/runtime/message_infrastructure/message_infrastructure/multiprocessing.py
Show resolved
Hide resolved
src/lava/magma/runtime/message_infrastructure/message_infrastructure/multiprocessing.py
Outdated
Show resolved
Hide resolved
1. multiprocessing.py: Fix bug for sharedmemmanager name 2. remove lava package dependency for message_infrastructure 3. multiprocessing.cc: Add shmm and actors function 4. abstract_actor.h: Modify the posix actor and interface design 5. add and update test for multiprocessing Signed-off-by: Miao, Hongda <[email protected]>
killight98
requested changes
Aug 17, 2022
hongdami
commented
Aug 17, 2022
killight98
requested changes
Aug 17, 2022
src/lava/magma/runtime/message_infrastructure/message_infrastructure/factory.py
Outdated
Show resolved
Hide resolved
src/lava/magma/runtime/message_infrastructure/message_infrastructure/factory.py
Outdated
Show resolved
Hide resolved
1. Move message_interface_enum.py to message_infrastructure 2. Update import syntax 3. Others: change multiprocessing init Signed-off-by: Miao, Hongda <[email protected]>
Signed-off-by: Miao, Hongda <[email protected]>
killight98
approved these changes
Aug 17, 2022
Signed-off-by: Miao, Hongda <[email protected]>
hexu33
approved these changes
Aug 17, 2022
seowwj
added a commit
to seowwj/lava
that referenced
this pull request
Aug 17, 2022
Merging PR lava-nc#310 from upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Objective of pull request:
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information