Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Pre Post Functions execution on board #323

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Make Pre Post Functions execution on board #323

merged 1 commit into from
Aug 26, 2022

Conversation

joyeshmishra
Copy link
Contributor

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

bamsumit
bamsumit approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@bamsumit bamsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect. Thanks Joyesh.

@joyeshmishra joyeshmishra merged commit 3698a0b into main Aug 26, 2022
@joyeshmishra joyeshmishra deleted the pre_post_fx branch August 26, 2022 19:27
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@joyeshmishra
Make Pre Post Functions execution on board (lava-nc#323)
5aae547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamsumit bamsumit bamsumit approved these changes

@ysingh7 ysingh7 ysingh7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyeshmishra @ysingh7 @bamsumit