Dev/learning rc 0.5 #332
Merged
Dev/learning rc 0.5 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into dev/learning_rc_0.5
…into dev/learning_rc_0.5 � Conflicts: � src/lava/magma/core/learning/constants.py
mathisrichter
requested changes
Sep 22, 2022
There was a problem hiding this comment.
After the live code review, I suggest the following changes before we merge.
- Change the
Connectionbase class back to its ownLearningDenseclass for now until we have found a better solution. - Reorder the classes and methods in the modules by starting from the most important classes/methods at the top and putting everything that is used right underneath.
- Create an issue to unit test at least the user interface.
- Create an issue to refactor the code for reuse (removing the redundant implementation of the floating point and fixed point ProcModels).
Everything else looks good. Great job everyone!
mathisrichter
approved these changes
Sep 22, 2022
…into dev/learning_rc_0.5
gkarray
approved these changes
Sep 23, 2022
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* inheritance from base class * inheritance from base connection * floating point model * minor cleanup * added neuron base class * separate models from process files * rm init file * inherit from Neuron and Connection * merged LearningDense into Dense * release candidate 0.5a * beginning last clean * clean in progress * updated tutorial * changes according to checklist made. missing use of np.where refactor * changed evaluate_trace to use boolean indexing instead of np.where * removed BITS_ * lint and poetry update * moved tutorial to in_depth * Licenses * lint tests * poetry update * docstrings for connection and learning rule * fixing typo * minor optimization for floating point model * added learning related unit tests * added other learning related unit tests * refactored docstrings * merged Loihi1 and 2 LearningRules and added seed for RNGs * fixing failing tests * fixing lint errors * fixing lint errors * fixing failing tests * fixing failing tests * docstrings and minor changes * adding apply_mask to learning/utils * lint and rng seed * pulled pyproject and poetry from main * re-add asteval as dependency * vectorizing decompose_impulses, adding some constants * typos * return of the LearningDense class * Connection base class to reduce code duplication * lint * rm learning rule base class * minor bug fix * added tutorial for custom learning rules * added test for LearningDense process * pull lock and pyproject from main * added tests for multisynapse learning * use LearningDense in tests Co-authored-by: gkarray <[email protected]> Co-authored-by: Marcus G K Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Objective of pull request:
This PR enables 2-factor online learning on CPU as a simulation of the Loihi learning engine.
The main changes are:
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information