Add Missing Variables in Conv Model #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamsumit
requested changes
Sep 22, 2022
mgkwill
approved these changes
Sep 23, 2022
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* add missing variables * Remove redundant vars from models.py Co-authored-by: Marcus G K Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #353
Objective of pull request: Conv Process and PyConvModelFloat don't have the same Variables. As a quick fix, I added weight_exp and num_weight_bits to the AbstractPyConvModel. One could alternatively add these variables to PyConvModelFloat or not declare them as Var in Conv.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
Running the Conv Process with PyConvModelFloat throws "AssertionError: Both Process 'Conv' and ProcessModel 'PyConvModelFloat' are expected to have Var named 'num_weight_bits'." as the Process and its Model don't have the exact same Variables.
Does this introduce a breaking change?