Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use poetry 1.1.15 explicitly #365

Merged
merged 11 commits into from
Sep 23, 2022
Merged

Conversation

srrisbud
Copy link
Contributor

Issue Number:

Objective of pull request: Use a specific version of poetry (1.1.15) to avoid unnecessary CI failures at "install dependency" stage

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Copy link
Contributor

@PhilippPlank PhilippPlank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this fixes some CI issues, great!

Copy link
Contributor

@weidel-p weidel-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks!

@PhilippPlank PhilippPlank merged commit ca0947c into lava-nc:main Sep 23, 2022
@mgkwill
Copy link
Contributor

mgkwill commented Sep 23, 2022

This fixes an issue where the newest version of poetry is not installed correctly by the github action we use to install poetry. Pegging to this version allows install to proceed and doesn't affect lava as lava works with 1.1.x or 1.2.x.

This was updated last night in another repo, but it wasn't clear at the time that the issue was present in upstream repos.

monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* SCIF neuron model for QUBO, CSP, etc.

Signed-off-by: Risbud, Sumedh <[email protected]>

* SCIF neuron model for QUBO, CSP, etc.

Signed-off-by: Risbud, Sumedh <[email protected]>

* Minor import fix

Signed-off-by: Risbud, Sumedh <[email protected]>

* Enabled Get/Set for synaptic weights

Signed-off-by: Risbud, Sumedh <[email protected]>

* Use poetry 1.1.15

Signed-off-by: Risbud, Sumedh <[email protected]>

Signed-off-by: Risbud, Sumedh <[email protected]>
Co-authored-by: Marcus G K Williams <[email protected]>
Co-authored-by: PhilippPlank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants