Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCIF neuron model: Minor fixes #367

Merged
merged 10 commits into from
Sep 23, 2022
Merged

SCIF neuron model: Minor fixes #367

merged 10 commits into from
Sep 23, 2022

Conversation

srrisbud
Copy link
Contributor

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@srrisbud
SCIF neuron model for QUBO, CSP, etc.
a5987e1 
Signed-off-by: Risbud, Sumedh <[email protected]>
@srrisbud
SCIF neuron model for QUBO, CSP, etc.
09ae94f 
Signed-off-by: Risbud, Sumedh <[email protected]>
@srrisbud
Merge branch 'scif_neuron_model' of https://github.com/srrisbud/lava …
96a09cf 
…into scif_neuron_model
@srrisbud
Minor import fix
ebe7b81 
Signed-off-by: Risbud, Sumedh <[email protected]>
@srrisbud
SCIF: Enabled QUBO support
e24805e 
Signed-off-by: Risbud, Sumedh <[email protected]>
@srrisbud
Merge branch 'main' of https://github.com/lava-nc/lava into scif_neur…
74708f7 
…on_model
@srrisbud
Merge branch 'main' of https://github.com/lava-nc/lava into scif_neur…
5f82057 
…on_model
@srrisbud
Merge branch 'scif_neuron_model' of https://github.com/srrisbud/lava …
840dd85 
…into scif_neuron_model
@srrisbud
Minor fixes post review by @phstratmann
12a3178 
Signed-off-by: Risbud, Sumedh <[email protected]>
@srrisbud
Merge branch 'main' of https://github.com/lava-nc/lava into scif_neur…
7a205bf 
…on_model
@srrisbud srrisbud self-assigned this Sep 23, 2022
GaboFGuerra
GaboFGuerra approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@GaboFGuerra GaboFGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sumedh!

@mgkwill mgkwill merged commit c91a734 into lava-nc:main Sep 23, 2022
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@srrisbud
SCIF neuron model: Minor fixes (lava-nc#367)
7120a21 
* SCIF neuron model for QUBO, CSP, etc.

Signed-off-by: Risbud, Sumedh <[email protected]>

* Minor import fix

Signed-off-by: Risbud, Sumedh <[email protected]>

* SCIF: Enabled QUBO support

Signed-off-by: Risbud, Sumedh <[email protected]>

* Minor fixes post review by @phstratmann

Signed-off-by: Risbud, Sumedh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishrao7 ashishrao7 ashishrao7 approved these changes

@GaboFGuerra GaboFGuerra GaboFGuerra approved these changes

@phstratmann phstratmann Awaiting requested review from phstratmann

Assignees

@srrisbud srrisbud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srrisbud @ashishrao7 @GaboFGuerra @mgkwill