Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate design issues in learning-related code #371

Merged
merged 5 commits into from
Sep 26, 2022
Merged

Eliminate design issues in learning-related code #371

merged 5 commits into from
Sep 26, 2022

Conversation

mathisrichter
Copy link
Contributor

Issue Number:

Objective of pull request: The base classes for the learning-related ProcessModels (Connection and its subclasses) were accessing members that are only defined in its subclasses. This PR also eliminates parts of the code duplication.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@mathisrichter mathisrichter added the 1-bug Something isn't working label Sep 26, 2022
@mathisrichter mathisrichter self-assigned this Sep 26, 2022
weidel-p
weidel-p approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@weidel-p weidel-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate that you improved the code and removed duplications. GH and I brought back some pieces we think are necessary. Looks good otherwise.

@mgkwill mgkwill merged commit 6eaa516 into lava-nc:main Sep 26, 2022
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@mathisrichter @weidel-p @mgkwill
Eliminate design issues in learning-related code (lava-nc#371)
0886cb8 
* Refactored to eliminate design issues.

Signed-off-by: Mathis Richter <[email protected]>

* Added a todo.

Signed-off-by: Mathis Richter <[email protected]>

* brought back sign mode and set weights

* lint

Signed-off-by: Mathis Richter <[email protected]>
Co-authored-by: Philipp Weidel <[email protected]>
Co-authored-by: Marcus G K Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkarray gkarray gkarray approved these changes

@weidel-p weidel-p weidel-p approved these changes

Assignees

@mathisrichter mathisrichter

Labels
1-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mathisrichter @weidel-p @gkarray @mgkwill