Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable exception proc_map, working with dataclasses, etc. #372

Merged
merged 4 commits into from
Sep 27, 2022
Merged

Enable exception proc_map, working with dataclasses, etc. #372

merged 4 commits into from
Sep 27, 2022

Conversation

GaboFGuerra
Copy link
Contributor

Signed-off-by: GaboFGuerra [email protected]

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@mgkwill mgkwill marked this pull request as ready for review September 27, 2022 17:53
bamsumit
bamsumit approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@bamsumit bamsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues to discuss later

@joyeshmishra joyeshmishra merged commit 15c2574 into lava-nc:main Sep 27, 2022
@joyeshmishra joyeshmishra deleted the optimization_features branch September 27, 2022 20:08
This was referenced Sep 28, 2022
Open
Open
mgkwill added a commit that referenced this pull request Sep 28, 2022
@GaboFGuerra @mgkwill @joyeshmishra
Enable exception proc_map, working with dataclasses, etc. (#372)
c294760 
* Enable exception proc_map, working with dataclasses, etc.

Signed-off-by: GaboFGuerra <[email protected]>

* Fix lint issue and check if run_cfg has exception model map

Signed-off-by: GaboFGuerra <[email protected]>
Co-authored-by: Marcus G K Williams <[email protected]>
Co-authored-by: Joyesh Mishra <[email protected]>
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@GaboFGuerra @mgkwill @joyeshmishra
Enable exception proc_map, working with dataclasses, etc. (lava-nc#372)
ba559ee 
* Enable exception proc_map, working with dataclasses, etc.

Signed-off-by: GaboFGuerra <[email protected]>

* Fix lint issue and check if run_cfg has exception model map

Signed-off-by: GaboFGuerra <[email protected]>
Co-authored-by: Marcus G K Williams <[email protected]>
Co-authored-by: Joyesh Mishra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeshmishra joyeshmishra joyeshmishra approved these changes

@bamsumit bamsumit bamsumit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GaboFGuerra @joyeshmishra @bamsumit @mgkwill